Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the base path in the CLI #2756

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix the base path in the CLI #2756

merged 1 commit into from
Jul 31, 2024
+37 −31

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Jul 31, 2024 •
edited
Loading

This is an alternative to #2395 with absolute links

Both /basepath and /basepath/ work

Closes #2285

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Jul 31, 2024
@jkelleyrtp jkelleyrtp mentioned this pull request Jul 31, 2024
Closed
jkelleyrtp
jkelleyrtp approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really set up a harness so these things stay more stable.

@jkelleyrtp jkelleyrtp merged commit b8565e6 into DioxusLabs:main Jul 31, 2024
13 checks passed
@ealmloff ealmloff deleted the fix-base-path branch July 31, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base_path needed for deploy, but breaks local serve
2 participants
@ealmloff @jkelleyrtp